chenjl/canal
1
0
Fork 0
mirror of https://github.com/alibaba/canal.git synced 2026-11-04 00:30:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure super.stop() is called exactly once in CanalRabbitMQProducer (#5578)

Browse Source 
Previously super.stop() was called both inside the try block and after
the catch blocks. On success it was invoked twice; on IOException it was
never reached. Move super.stop() to a finally block so it executes
exactly once regardless of whether close() succeeds or fails.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Guimu
2026-04-23 14:09:05 +08:00
committed by GitHub
parent 5110cfd49d
commit 8a5dc38a58
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
connector/rabbitmq-connector/src/main/java/com/alibaba/otter/canal/connector/rabbitmq/producer/CanalRabbitMQProducer.java
View File

@@ -210,13 +210,12 @@ public class CanalRabbitMQProducer extends AbstractMQProducer implements CanalMQ
try { try {
this.channel.close(); this.channel.close();
this.connect.close(); this.connect.close();
super.stop();
} catch (AlreadyClosedException ex) { } catch (AlreadyClosedException ex) {
logger.error("Connection is already closed", ex); logger.error("Connection is already closed", ex);
} catch (IOException | TimeoutException ex) { } catch (IOException | TimeoutException ex) {
throw new CanalException("Stop RabbitMQ producer error", ex); throw new CanalException("Stop RabbitMQ producer error", ex);
} finally {
super.stop();
} }
super.stop();
} }
} }