From a78622ae0294c9c36b177d42edf74fddc11b09c6 Mon Sep 17 00:00:00 2001 From: yinxiu Date: Tue, 28 Mar 2017 20:33:14 +0800 Subject: [PATCH] rename log manager module and ajust xml --- .../src/main/resources/spring/default-instance.xml | 10 +++++----- .../src/main/resources/spring/file-instance.xml | 10 +++++----- .../src/main/resources/spring/local-instance.xml | 10 +++++----- .../canal/instance/core/AbstractCanalInstance.java | 6 +++--- .../instance/manager/CanalInstanceWithManager.java | 6 +++--- .../src/test/resources/spring/default-instance.xml | 10 +++++----- .../src/test/resources/spring/file-instance.xml | 14 ++++++++------ .../canal/parse/inbound/AbstractEventParser.java | 8 ++++---- .../inbound/mysql/LocalBinlogEventParser.java | 4 ++-- .../parse/index/AbstractLogPositionManager.java | 2 +- ...onManager.java => CanalLogPositionManager.java} | 2 +- ...anager.java => FailbackLogPositionManager.java} | 10 +++++----- .../index/FileMixedLogPositionManagerTest.java | 10 ++++------ 13 files changed, 51 insertions(+), 51 deletions(-) rename parse/src/main/java/com/alibaba/otter/canal/parse/index/{LogPositionManager.java => CanalLogPositionManager.java} (87%) rename parse/src/main/java/com/alibaba/otter/canal/parse/index/{FailoverLogPositionManager.java => FailbackLogPositionManager.java} (87%) diff --git a/deployer/src/main/resources/spring/default-instance.xml b/deployer/src/main/resources/spring/default-instance.xml index 4e092257..5631b7cb 100644 --- a/deployer/src/main/resources/spring/default-instance.xml +++ b/deployer/src/main/resources/spring/default-instance.xml @@ -128,14 +128,14 @@ - + - - + + - + - + diff --git a/deployer/src/main/resources/spring/file-instance.xml b/deployer/src/main/resources/spring/file-instance.xml index 191d0c11..b5fcc908 100644 --- a/deployer/src/main/resources/spring/file-instance.xml +++ b/deployer/src/main/resources/spring/file-instance.xml @@ -113,14 +113,14 @@ - + - - + + - + - + diff --git a/deployer/src/main/resources/spring/local-instance.xml b/deployer/src/main/resources/spring/local-instance.xml index 52cdf404..e5e4e695 100644 --- a/deployer/src/main/resources/spring/local-instance.xml +++ b/deployer/src/main/resources/spring/local-instance.xml @@ -123,14 +123,14 @@ - + - - + + - + - + diff --git a/instance/core/src/main/java/com/alibaba/otter/canal/instance/core/AbstractCanalInstance.java b/instance/core/src/main/java/com/alibaba/otter/canal/instance/core/AbstractCanalInstance.java index 70a03447..03dfb200 100644 --- a/instance/core/src/main/java/com/alibaba/otter/canal/instance/core/AbstractCanalInstance.java +++ b/instance/core/src/main/java/com/alibaba/otter/canal/instance/core/AbstractCanalInstance.java @@ -2,7 +2,7 @@ package com.alibaba.otter.canal.instance.core; import java.util.List; -import com.alibaba.otter.canal.parse.index.LogPositionManager; +import com.alibaba.otter.canal.parse.index.CanalLogPositionManager; import org.apache.commons.lang.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -171,7 +171,7 @@ public class AbstractCanalInstance extends AbstractCanalLifeCycle implements Can if (eventParser instanceof AbstractEventParser) { AbstractEventParser abstractEventParser = (AbstractEventParser) eventParser; // 首先启动log position管理器 - LogPositionManager logPositionManager = abstractEventParser.getLogPositionManager(); + CanalLogPositionManager logPositionManager = abstractEventParser.getLogPositionManager(); if (!logPositionManager.isStart()) { logPositionManager.start(); } @@ -196,7 +196,7 @@ public class AbstractCanalInstance extends AbstractCanalLifeCycle implements Can if (eventParser instanceof AbstractEventParser) { AbstractEventParser abstractEventParser = (AbstractEventParser) eventParser; // 首先启动log position管理器 - LogPositionManager logPositionManager = abstractEventParser.getLogPositionManager(); + CanalLogPositionManager logPositionManager = abstractEventParser.getLogPositionManager(); if (logPositionManager.isStart()) { logPositionManager.stop(); } diff --git a/instance/manager/src/main/java/com/alibaba/otter/canal/instance/manager/CanalInstanceWithManager.java b/instance/manager/src/main/java/com/alibaba/otter/canal/instance/manager/CanalInstanceWithManager.java index a10140b4..2e8dbae9 100644 --- a/instance/manager/src/main/java/com/alibaba/otter/canal/instance/manager/CanalInstanceWithManager.java +++ b/instance/manager/src/main/java/com/alibaba/otter/canal/instance/manager/CanalInstanceWithManager.java @@ -338,10 +338,10 @@ public class CanalInstanceWithManager extends AbstractCanalInstance { return haController; } - protected LogPositionManager initLogPositionManager() { + protected CanalLogPositionManager initLogPositionManager() { logger.info("init logPositionPersistManager begin..."); IndexMode indexMode = parameters.getIndexMode(); - LogPositionManager logPositionManager; + CanalLogPositionManager logPositionManager; if (indexMode.isMemory()) { logPositionManager = new MemoryLogPositionManager(); } else if (indexMode.isZookeeper()) { @@ -356,7 +356,7 @@ public class CanalInstanceWithManager extends AbstractCanalInstance { MemoryLogPositionManager primary = new MemoryLogPositionManager(); MetaLogPositionManager secondary = new MetaLogPositionManager(metaManager); - logPositionManager = new FailoverLogPositionManager(primary, secondary); + logPositionManager = new FailbackLogPositionManager(primary, secondary); } else { throw new CanalException("unsupport indexMode for " + indexMode); } diff --git a/instance/spring/src/test/resources/spring/default-instance.xml b/instance/spring/src/test/resources/spring/default-instance.xml index 0e035319..417934da 100644 --- a/instance/spring/src/test/resources/spring/default-instance.xml +++ b/instance/spring/src/test/resources/spring/default-instance.xml @@ -120,14 +120,14 @@ - + - - + + - + - + diff --git a/instance/spring/src/test/resources/spring/file-instance.xml b/instance/spring/src/test/resources/spring/file-instance.xml index 1acd7050..fcd0a78f 100644 --- a/instance/spring/src/test/resources/spring/file-instance.xml +++ b/instance/spring/src/test/resources/spring/file-instance.xml @@ -102,18 +102,20 @@ - + - + - - + + - + + + - + diff --git a/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/AbstractEventParser.java b/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/AbstractEventParser.java index 270f739b..0fed2ef0 100644 --- a/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/AbstractEventParser.java +++ b/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/AbstractEventParser.java @@ -8,7 +8,7 @@ import java.util.TimerTask; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicLong; -import com.alibaba.otter.canal.parse.index.LogPositionManager; +import com.alibaba.otter.canal.parse.index.CanalLogPositionManager; import org.apache.commons.lang.StringUtils; import org.apache.commons.lang.exception.ExceptionUtils; import org.apache.commons.lang.math.RandomUtils; @@ -44,7 +44,7 @@ public abstract class AbstractEventParser extends AbstractCanalLifeCycle protected final Logger logger = LoggerFactory.getLogger(this.getClass()); - protected LogPositionManager logPositionManager = null; + protected CanalLogPositionManager logPositionManager = null; protected CanalEventSink> eventSink = null; protected CanalEventFilter eventFilter = null; protected CanalEventFilter eventBlackFilter = null; @@ -495,7 +495,7 @@ public abstract class AbstractEventParser extends AbstractCanalLifeCycle return this.alarmHandler; } - public void setLogPositionManager(LogPositionManager logPositionManager) { + public void setLogPositionManager(CanalLogPositionManager logPositionManager) { this.logPositionManager = logPositionManager; } @@ -503,7 +503,7 @@ public abstract class AbstractEventParser extends AbstractCanalLifeCycle this.transactionSize = transactionSize; } - public LogPositionManager getLogPositionManager() { + public CanalLogPositionManager getLogPositionManager() { return logPositionManager; } diff --git a/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogEventParser.java b/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogEventParser.java index 6334c464..a0b32177 100644 --- a/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogEventParser.java +++ b/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogEventParser.java @@ -2,7 +2,7 @@ package com.alibaba.otter.canal.parse.inbound.mysql; import java.io.IOException; -import com.alibaba.otter.canal.parse.index.LogPositionManager; +import com.alibaba.otter.canal.parse.index.CanalLogPositionManager; import org.apache.commons.lang.StringUtils; import com.alibaba.otter.canal.parse.CanalEventParser; @@ -150,7 +150,7 @@ public class LocalBinlogEventParser extends AbstractMysqlEventParser implements // ========================= setter / getter ========================= - public void setLogPositionManager(LogPositionManager logPositionManager) { + public void setLogPositionManager(CanalLogPositionManager logPositionManager) { this.logPositionManager = logPositionManager; } diff --git a/parse/src/main/java/com/alibaba/otter/canal/parse/index/AbstractLogPositionManager.java b/parse/src/main/java/com/alibaba/otter/canal/parse/index/AbstractLogPositionManager.java index 914e4c00..2c3c95da 100644 --- a/parse/src/main/java/com/alibaba/otter/canal/parse/index/AbstractLogPositionManager.java +++ b/parse/src/main/java/com/alibaba/otter/canal/parse/index/AbstractLogPositionManager.java @@ -6,5 +6,5 @@ import com.alibaba.otter.canal.common.AbstractCanalLifeCycle; * Created by yinxiu on 17/3/17. * Email: marklin.hz@gmail.com */ -public abstract class AbstractLogPositionManager extends AbstractCanalLifeCycle implements LogPositionManager { +public abstract class AbstractLogPositionManager extends AbstractCanalLifeCycle implements CanalLogPositionManager { } diff --git a/parse/src/main/java/com/alibaba/otter/canal/parse/index/LogPositionManager.java b/parse/src/main/java/com/alibaba/otter/canal/parse/index/CanalLogPositionManager.java similarity index 87% rename from parse/src/main/java/com/alibaba/otter/canal/parse/index/LogPositionManager.java rename to parse/src/main/java/com/alibaba/otter/canal/parse/index/CanalLogPositionManager.java index 3edd0968..7947231d 100644 --- a/parse/src/main/java/com/alibaba/otter/canal/parse/index/LogPositionManager.java +++ b/parse/src/main/java/com/alibaba/otter/canal/parse/index/CanalLogPositionManager.java @@ -8,7 +8,7 @@ import com.alibaba.otter.canal.protocol.position.LogPosition; * Created by yinxiu on 17/3/17. * Email: marklin.hz@gmail.com */ -public interface LogPositionManager extends CanalLifeCycle { +public interface CanalLogPositionManager extends CanalLifeCycle { LogPosition getLatestIndexBy(String destination); diff --git a/parse/src/main/java/com/alibaba/otter/canal/parse/index/FailoverLogPositionManager.java b/parse/src/main/java/com/alibaba/otter/canal/parse/index/FailbackLogPositionManager.java similarity index 87% rename from parse/src/main/java/com/alibaba/otter/canal/parse/index/FailoverLogPositionManager.java rename to parse/src/main/java/com/alibaba/otter/canal/parse/index/FailbackLogPositionManager.java index 6f36aeae..fd2066f6 100644 --- a/parse/src/main/java/com/alibaba/otter/canal/parse/index/FailoverLogPositionManager.java +++ b/parse/src/main/java/com/alibaba/otter/canal/parse/index/FailbackLogPositionManager.java @@ -15,14 +15,14 @@ import org.slf4j.LoggerFactory; * 应用场景：比如针对内存buffer，出现HA切换，先尝试从内存buffer区中找到lastest position，如果不存在才尝试找一下meta里消费的信息 * */ -public class FailoverLogPositionManager extends AbstractLogPositionManager { +public class FailbackLogPositionManager extends AbstractLogPositionManager { - private final static Logger logger = LoggerFactory.getLogger(FailoverLogPositionManager.class); + private final static Logger logger = LoggerFactory.getLogger(FailbackLogPositionManager.class); - private final LogPositionManager primary; - private final LogPositionManager secondary; + private final CanalLogPositionManager primary; + private final CanalLogPositionManager secondary; - public FailoverLogPositionManager(LogPositionManager primary, LogPositionManager secondary) { + public FailbackLogPositionManager(CanalLogPositionManager primary, CanalLogPositionManager secondary) { if (primary == null) { throw new NullPointerException("nul primary LogPositionManager"); } diff --git a/parse/src/test/java/com/alibaba/otter/canal/parse/index/FileMixedLogPositionManagerTest.java b/parse/src/test/java/com/alibaba/otter/canal/parse/index/FileMixedLogPositionManagerTest.java index ac1449b4..5d185648 100644 --- a/parse/src/test/java/com/alibaba/otter/canal/parse/index/FileMixedLogPositionManagerTest.java +++ b/parse/src/test/java/com/alibaba/otter/canal/parse/index/FileMixedLogPositionManagerTest.java @@ -26,17 +26,15 @@ public class FileMixedLogPositionManagerTest extends AbstractLogPositionManagerT @Test public void testAll() { - FileMixedLogPositionManager logPositionManager = new FileMixedLogPositionManager(); - logPositionManager.setDataDir(dataDir); - logPositionManager.setPeriod(100); + MemoryLogPositionManager memoryLogPositionManager = new MemoryLogPositionManager(); + + FileMixedLogPositionManager logPositionManager = new FileMixedLogPositionManager(dataDir, 1000, memoryLogPositionManager); logPositionManager.start(); LogPosition position2 = doTest(logPositionManager); sleep(1500); - FileMixedLogPositionManager logPositionManager2 = new FileMixedLogPositionManager(); - logPositionManager2.setDataDir(dataDir); - logPositionManager2.setPeriod(100); + FileMixedLogPositionManager logPositionManager2 = new FileMixedLogPositionManager(dataDir, 1000, memoryLogPositionManager); logPositionManager2.start(); LogPosition getPosition2 = logPositionManager2.getLatestIndexBy(destination);