chenjl/canal
1
0
Fork 0
mirror of https://github.com/alibaba/canal.git synced 2026-11-04 00:30:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix:Alibaba Coding Guidelines-Object的equals方法容易抛空指针异常，应使用常量或确定有值的对象来调用equals。 (#2919)

Browse Source
This commit is contained in:
Tocker
2020-08-20 21:17:44 +08:00
committed by GitHub
parent 576406a4ce
commit b82c8bca83
13 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
client-adapter/rdb/src/main/java/com/alibaba/otter/canal/client/adapter/rdb/service/RdbSyncService.java
View File

@@ -208,13 +208,13 @@ public class RdbSyncService {
if (config != null) {
try {
String type = dml.getType();
if (type != null && type.equalsIgnoreCase("INSERT")) {
if (type != null && "INSERT".equalsIgnoreCase(type)) {
insert(batchExecutor, config, dml);
} else if (type != null && type.equalsIgnoreCase("UPDATE")) {
} else if (type != null && "UPDATE".equalsIgnoreCase(type)) {
update(batchExecutor, config, dml);
} else if (type != null && type.equalsIgnoreCase("DELETE")) {
} else if (type != null && "DELETE".equalsIgnoreCase(type)) {
delete(batchExecutor, config, dml);
} else if (type != null && type.equalsIgnoreCase("TRUNCATE")) {
} else if (type != null && "TRUNCATE".equalsIgnoreCase(type)) {
truncate(batchExecutor, config);
}
if (logger.isDebugEnabled()) {

2
client-adapter/rdb/src/main/java/com/alibaba/otter/canal/client/adapter/rdb/support/SyncUtil.java
View File

@@ -71,7 +71,7 @@ public class SyncUtil {
if (value instanceof Boolean) {
pstmt.setBoolean(i, (Boolean) value);
} else if (value instanceof String) {
boolean v = !value.equals("0");
boolean v = !"0".equals(value);
pstmt.setBoolean(i, v);
} else if (value instanceof Number) {
boolean v = ((Number) value).intValue() != 0;