= code cleanup

This commit is contained in:
zavakid
2020-09-16 14:18:05 +08:00
parent b81e9dfeb8
commit df60eda679

View File

@@ -2,7 +2,6 @@ package com.alibaba.otter.canal.server.embedded;
import java.security.NoSuchAlgorithmException; import java.security.NoSuchAlgorithmException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections; import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
@@ -566,8 +565,12 @@ public class CanalServerWithEmbedded extends AbstractCanalLifeCycle implements C
for (CanalMetricsProvider provider : providers) { for (CanalMetricsProvider provider : providers) {
list.add(provider); list.add(provider);
} }
if (!list.isEmpty()) {
// 发现provider, 进行初始化 if (list.isEmpty()) {
return;
}
// only allow ONE provider
if (list.size() > 1) { if (list.size() > 1) {
logger.warn("Found more than one CanalMetricsProvider, use the first one."); logger.warn("Found more than one CanalMetricsProvider, use the first one.");
// 报告冲突 // 报告冲突
@@ -575,11 +578,10 @@ public class CanalServerWithEmbedded extends AbstractCanalLifeCycle implements C
logger.warn("Found CanalMetricsProvider: {}.", p.getClass().getName()); logger.warn("Found CanalMetricsProvider: {}.", p.getClass().getName());
} }
} }
// 默认使用第一个
CanalMetricsProvider provider = list.get(0); CanalMetricsProvider provider = list.get(0);
this.metrics = provider.getService(); this.metrics = provider.getService();
} }
}
private boolean isRaw(CanalEventStore eventStore) { private boolean isRaw(CanalEventStore eventStore) {
if (eventStore instanceof MemoryEventStoreWithBuffer) { if (eventStore instanceof MemoryEventStoreWithBuffer) {